feat(react): Add support for React Router createMemoryRouter
#14854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/react-initial-entries
branch
from
e479bde to
9f1cd47
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
onurtemizkan
force-pushed
the
onur/react-initial-entries
branch
from
9f1cd47 to
6a7c1a0
Compare
Contributor
I actually think this idea isn't too bad. 🤔 Would it be a lot of effort? |
onurtemizkan
force-pushed
the
onur/react-initial-entries
branch
from
6a7c1a0 to
358452f
Compare
onurtemizkan
force-pushed
the
onur/react-initial-entries
branch
from
54cb551 to
ea95f26
Compare
Collaborator
Author
|
@lforst - Updated the PR to export |
lforst
changed the title
initialEntries in wrapped routers.createMemoryRouter
lforst
approved these changes
Jan 10, 2025
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
I took the liberty to do 2 functions instead of the boolean arg. I have seen that pattern go bad very quickly.
Otherwise looks great to me! We shouldn't forget to add docs.
onurtemizkan
added a commit
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #14814
I was not able to properly distinguish between the instances of
BrowserRouterandMemoryRouter. However, usinginitialEntrieswithBrowserRoutershould break TypeScript where it's available. We can alternatively export a wrapper specific toMemoryRouterif that makes better sense.